Merged
Conversation
egparedes
reviewed
Nov 28, 2025
Collaborator
egparedes
left a comment
There was a problem hiding this comment.
As discussed offline, I think the current "pull" approach where the index repo request sources from the package repos and builds the wheels itself is the wrong design, and this repo should follow the opposite ("push") approach where the packages repos upload the wheel here.
Realistically, the current approach could be good enough as a first step and we don't need to change it if it works well for our purposes, so I'm ok with the current PR, although would like to add a comment about the two approaches in the README.
Also, instead of merging all the code in one PR, I would split the PR into two:
- for the first one should be enough to just have one version of the important packages (DaCe and GHEX) uploaded by hand to test the functionality of serving as as index server
- the second PR could add the update mechanism hooks, which in the worst case can be postponed a bit and do the updates manually for a while
Co-authored-by: Enrique González Paredes <enriqueg@cscs.ch>
Co-authored-by: Enrique González Paredes <enriqueg@cscs.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first draft that already works, kind of.
The workflow already works, not tested on this repo, but on my [development repo]https://github.com/philip-paul-mueller/test_package_index) it works already.
What is still missing: